On Tue, 10 Feb 2026 06:10:26 GMT, Chen Liang <[email protected]> wrote:

>> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/X-Vector.java.template
>>  line 5396:
>> 
>>> 5394:     }
>>> 5395: 
>>> 5396:     @Override
>> 
>> For sake of uniformity you should add /*package-private*/ comment over newly 
>> defined swapIfNeeded method.
>
> I think not having that is fine, the classes already have many 
> package-private method without such a comment.

Sounds reasonable. Not a blocker.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29616#discussion_r2786172501

Reply via email to