On Wed, 11 Feb 2026 20:12:19 GMT, Alexander Matveev <[email protected]> 
wrote:

>> - Version will be read from JDK's release file if not provided via 
>> `--version` for runtime installer.
>> - Added test to cover added functionality.
>> - On macOS and Windows version from JDK's release file will be normalized if 
>> it does not fit platform requirements.
>
> Alexander Matveev has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   8357404: jpackage should attempt to get a package version from the JDK's 
> release file if the --version option is not specified [v9]

src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxFromOptions.java line 
82:

> 80:             // In this case it should ensure the derived value is valid 
> RPM version.
> 81:             if (type.isPresent()) {
> 82:                 if (type.get().equals(LINUX_RPM)) {

The use of `OptionUtils.bundlingOperation(options) == 
StandardBundlingOperation.CREATE_LINUX_RPM` instead of the two conditions is 
simpler and eliminates the need to modify the signature of the 
`createLinuxApplication()` function.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29260#discussion_r2800649691

Reply via email to