On Thu, 12 Feb 2026 23:44:42 GMT, Alexander Matveev <[email protected]> wrote:
>> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WinFromOptions.java >> line 142: >> >>> 140: // We should drop any characters. For example: "-ea". >>> 141: return ver.toComponentsString(); >>> 142: } >> >> If I understand the code correctly, and the `version` variable is set to >> "17.2", then the function will return "17.2", right? But if it is "17.2.1", >> it will return "17.2.1.0". Is this what we want? > > Yes. We want to normalize only if version is not complaint with target > package requirements. If normalization is required it will be always done to > 4 components. 17 -> 17.0.0.0. Ok, but why "17.2" is a special case: 17 -> 17.0.0.0 17.2 -> 17.2 17.2.3 -> 17.2.3.0 ? And another question. If "17.2" is OK, then why don't we convert "17" into "17.0" instead of "17.0.0.0"? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29260#discussion_r2801594960
