On Wed, 18 Feb 2026 10:42:01 GMT, David Beaumont <[email protected]> wrote:
> Removed the manual file tidyup on the expectation that jtreg will sort that
> all out.
> Switched to using Utils.createTempFile() while I was there.
test/jdk/tools/jimage/JImageBadFileTest.java line 82:
> 80: throws IOException {
> 81: int remaining = maxLen >= 0 ? maxLen : Integer.MAX_VALUE;
> 82: Path dst = Utils.createTempFile("modules-" + label, "");
Just curious why this is changed.
test/jdk/tools/jimage/JImageBadFileTest.java line 100:
> 98: } catch (IOException e) {
> 99: Files.deleteIfExists(dst);
> 100: throw e;
Good, this allows it to be saved in the event of a test failure too.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29783#discussion_r2826103532
PR Review Comment: https://git.openjdk.org/jdk/pull/29783#discussion_r2826106775
