On Mon, 23 Feb 2026 15:25:21 GMT, Alan Bateman <[email protected]> wrote:

>> test/jdk/tools/jimage/JImageBadFileTest.java line 145:
>> 
>>> 143:         // Self test that the file copying isn't itself corrupting 
>>> anything.
>>> 144:         Path tempJimage = writeModifiedJimage("good_file", -1, b -> 
>>> {});
>>> 145:         jimage("info", tempJimage.toString()).assertSuccess();
>> 
>> I know its a bit late to complain now, but "jimage" is not a very nor a very 
>> descriptive name of a central utility method.
>
> It's a method on JImageCliTest, the super class of the tests for the jimage 
> tool.

Yep, I tracked it down, its still not a good name.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29783#discussion_r2841877698

Reply via email to