Please review this PR which updates the specification of 
`ZipOutputStream.setComment(String)` to match the long-standing behavior of 
throwing `IllegalArgumentException` when a comment contains characters which 
are unmappable using the `Charset` passed in the constructor.

A new tests is added to reproduce calling setComment with unmappable characters 
and verify that it throws IAE.

A CSR has been drafted. Its specification section will be updated an initial 
round of review for the specification text in this PR.

-------------

Commit messages:
 - Update ZipOutputStream.setComment to declare that it throws 
IllegalArgumentException for unmappable characters in comment

Changes: https://git.openjdk.org/jdk/pull/30338/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=30338&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8380542
  Stats: 61 lines in 2 files changed: 59 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/30338.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/30338/head:pull/30338

PR: https://git.openjdk.org/jdk/pull/30338

Reply via email to