On Fri, 20 Mar 2026 15:45:56 GMT, Lance Andersen <[email protected]> wrote:
>>> I am unsure if accepting `null` should be a `@implSpec` or just a formal
>>> API specification.
>>
>> Me too. It's not like a subclass can affect the comment though other means
>> than this method. One could imagine a subclass that filters or rejects
>> comments. The distinction between these different spec levels is not super
>> clear to me.
>>
>> Perhaps other reviewers have opinions.
>>
>> I'll update the PR to your suggestion in any case - that way we have
>> something to base our discussion on.
>
> I think this can be just part of the specification.
I replaced the `@implSpec` with a note on the comment param. Here I also
mention that passing the empty string and null have equivalent effect:
* @param comment the comment string. Passing {@code null} or the empty
string
* will result in the output having no ZIP file comment
Have a look and let me know how you think this works.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30338#discussion_r2966873420
