On Mon, 16 Jun 2025 18:14:18 GMT, Roger Riggs <[email protected]> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   reduce comment
>
> src/java.base/unix/native/libjava/ProcessImpl_md.c line 86:
> 
>> 84:  *    powerful, but Linux-specific.
>> 85:  *
>> 86:  * D) posix_spawn(3): Where fork/vfork/clone all fork off the process 
>> and leave
> 
> I would downplay the OS launch options we don't use, only saying that vfork 
> is dangerous (and a bit as to why) but there's no need to mention clone. And 
> there's no need to mention the the deprecation or removal, when this is 
> integrated its gone.

Done. I also reduced the comment a lot, cutting away stuff we wrote around 2018 
since it affects glibc versions that are not relevant anymore.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25768#discussion_r2969187143

Reply via email to