On Sun, 29 Mar 2026 21:59:16 GMT, Andrew John Hughes <[email protected]> wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional >> commit since the last revision: >> >> reduce comment > > This looks good to me too. I appreciate it now being reduced down to just > the removal of `vfork` and I verified that the code paths for the other > implementations remain the same. All copyright headers are updated where > needed and it's good to see the back of some of the dated code & comments, > especially `execve_as_traditional_shell_script`. > > From reading this PR, the CSR and some of the history, it seems that the > writing was on the wall for `vfork` as soon as `posix_spawn` was added; at > least on Linux, this has the advantages of `vfork` but performed more safely. > With `posix_spawn` being the default for multiple LTS releases and `VFORK` > only being available on Linux as far back as I can see, I don't anticipate > removing this causing many issues. `FORK` seems like a sensible replacement > when an explicit option other than `POSIX_SPAWN` has been specified. Thank you, @gnu-andrew ! ------------- PR Comment: https://git.openjdk.org/jdk/pull/25768#issuecomment-4152163642
