On Fri, 27 Mar 2026 20:16:46 GMT, Paul Sandoz <[email protected]> wrote:
>> Emanuel Peter has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 33 additional >> commits since the last revision: >> >> - Merge branch 'master' into >> JDK-8375631-part-number-exception-and-documentation >> - more test >> - wip part number for unslice >> - fix up documentation a little more >> - more small updates >> - fix small issues >> - small fix in test and assert code >> - Merge branch 'master' into >> JDK-8375631-part-number-exception-and-documentation >> - more testing >> - cleanup and testReinterpret >> - ... and 23 more: https://git.openjdk.org/jdk/compare/5353689c...ee08c9ef > > src/jdk.incubator.vector/share/classes/jdk/incubator/vector/AbstractVector.java > line 505: > >> 503: int resSizeLog2 = domSizeLog2 + laneChangeLog2; >> 504: // resSizeLog2 = 0 => 1-lane vector shrinking to 1-byte >> lane-size >> 505: // resSizeLog2 < 0 => small vector shrinking by more than a >> lane-size > > Do you mean `resSizeLog2 > 0 ...`? I did not write this - it was already there before! But you are right it is obvious non-sense, given the assert below `assert(resSizeLog2 >= 0);` I think I'm going to just delete these two lines. Given all the other comments, they are now not very helpful any more. Let me know if you disagree. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30113#discussion_r3008223495
