On Fri, 27 Mar 2026 23:18:07 GMT, Paul Sandoz <[email protected]> wrote:
>> Emanuel Peter has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 33 additional >> commits since the last revision: >> >> - Merge branch 'master' into >> JDK-8375631-part-number-exception-and-documentation >> - more test >> - wip part number for unslice >> - fix up documentation a little more >> - more small updates >> - fix small issues >> - small fix in test and assert code >> - Merge branch 'master' into >> JDK-8375631-part-number-exception-and-documentation >> - more testing >> - cleanup and testReinterpret >> - ... and 23 more: https://git.openjdk.org/jdk/compare/b7ac1206...ee08c9ef > > The language overall is very very good. > > One approach to reduce the class documentation is to introduce the terms, > perhaps with some simple ASCII examples of the input vector, the logical > result vector and the output vector, and then present the table of examples. > The more detailed explanations can be placed into a separate HTML document > that we link to. That will provide a good balance for the developer who does > not have the time to read through all the details, and for those that want to > know more they can read further. @PaulSandoz Thanks for having a look! I addressed your comments :) > One approach to reduce the class documentation is to introduce the terms, > perhaps with some simple ASCII examples of the input vector, the logical > result vector and the output vector, and then present the table of examples. > The more detailed explanations can be placed into a separate HTML document > that we link to. That will provide a good balance for the developer who does > not have the time to read through all the details, and for those that want to > know more they can read further. Where would such a separate HTML document go exactly? The question is also what parts to move over. Currently, the important things are spread all throughout the "chapter". We would have to condense the important parts (definitions and acceptable part ranges, a few examples), and then put the extended version in the separate HTML document. But then other "chapters" are very long as well. For example, the lane-wise chapter is similarly long. What's our over-all strategy here? ------------- PR Comment: https://git.openjdk.org/jdk/pull/30113#issuecomment-4153228741
