On Mon, 30 Mar 2026 19:19:58 GMT, Chen Liang <[email protected]> wrote:
>> jengebr has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressing CR feedback (formatting + safe casts)
>
> src/java.base/share/classes/java/util/HashMap.java line 498:
>
>> 496: private void putMapEntries(HashMap<? extends K, ? extends V> src,
>> boolean evict) {
>> 497: if (src.table != null) {
>> 498: for (Node<? extends K, ? extends V> node : src.table) {
>
> This copy of iteration code imo causes future maintenance cost if iteration
> logic needs an update. I would prefer we just do an entry set iteration, and
> comment clearly that this copy of bytecode is for specialize exact type
> profiling (like the comments in #27533)
Will do!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28243#discussion_r3011768585
