On Mon, 30 Mar 2026 19:21:39 GMT, Chen Liang <[email protected]> wrote:

>> jengebr has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Addressing CR feedback (formatting + safe casts)
>
> src/java.base/share/classes/java/util/HashMap.java line 540:
> 
>> 538:                 putMapEntries(hashMap, evict);
>> 539:                 return;
>> 540:             }
> 
> Same comment, add comments to indicate the two branches have same 
> code/bytecode, they differ in the method profiling data which makes a huge 
> difference.

@jengebr I agree that some comments are indeed necessary. I'm tinkering with a 
way to simplify the special case logic, so don't worry about adding them just 
yet.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28243#discussion_r3011998185

Reply via email to