On Tue, 31 Mar 2026 19:39:12 GMT, Paul Sandoz <[email protected]> wrote:
>> Emanuel Peter has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix small typo
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Vector.java line
> 825:
>
>> 823: * produces a <em>logical result</em> that is too large for the
>> 824: * required physical output {@code VSHAPE}, so a part of the logical
>> 825: * output must be <em>selected</em> to deliver into the physical output.
>
> Suggestion:
>
> * required physical output {@code VSHAPE}, so a part of the logical
> * result must be <em>selected</em> to deliver into the physical output.
>
> ?
nice, makes it more consistent :)
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Vector.java line
> 850:
>
>> 848: * <p> In a nutshell, we would prefer to keep both {@code VSHAPE} and
>> 849: * {@code VLENGTH} constant in a block of vector code, but size
>> 850: * changes sometimes require messy compromises. Here are some
>
> Suggestion:
>
> * changes sometimes require compromises. Here are some
That was John's wording. But we can make it more formal, yes.
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Vector.java line
> 858:
>
>> 856: *
>> 857: * </li><li>The <em>physical output shape</em> of a vector operation
>> 858: * is the shape of the output container, the vector {@code Y} produced
>
> Suggestion:
>
> * is the shape of the output, the vector {@code Y} produced
We used to talk about containers for a while, but I think we can drop the word
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30113#discussion_r3019788384
PR Review Comment: https://git.openjdk.org/jdk/pull/30113#discussion_r3019789115
PR Review Comment: https://git.openjdk.org/jdk/pull/30113#discussion_r3019790451
