On Tue, 7 Apr 2026 20:23:58 GMT, Eirik Bjørsnøs <[email protected]> wrote:
> Let's see what Alan/Jai have for a preference. The Charset is used to encode entry names and comments so it's okay to say that. I see Eirik has inlined another patch. The class description part is okay except for "uses UTF-8 to encode strings". This is problematic because it jumps from entry names and comments to "strings", we should keep it consistent as otherwise it creates doubt that the 1-arg and 2-arg constructors do something different. For the same reason, I don't think the changes in the inlined patch to the setComment and constructors should be included. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30338#discussion_r3049829436
