On Wed, 8 Apr 2026 13:06:39 GMT, Eirik Bjørsnøs <[email protected]> wrote:
>> I would prefer "specified" vs. "provided" in the above
>>
>> WRT:
>>
>>> A stream created without specifying
>>> + * a {@code Charset} uses UTF-8 to encode strings.
>>
>> I might wordsmith a bit more to something similar to
>>
>> By default, the UTF-8 charset is used to encode entry names and comments.
>> ZipOutPutStream(OutputStream, CharSet) maybe be used to specify an
>> alternative charset)
>
>> I would prefer "specified" vs. "provided" in the above
>
> I have updated the inline patch above to use "specified". Still seeking
> guidance whether this change to the constructors should be included in the PR
> or if it is better to leave them alone for now.
>
>> I might wordsmith a bit more to something similar to
>>
>> By default, the UTF-8 charset is used to encode entry names and comments.
>> ZipOutPutStream(OutputStream, CharSet) maybe be used to specify an
>> alternative charset)
>
> Thanks, introducing the default before alternatives makes sense. See latest
> version.
I think the changes are much better and clearer
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30338#discussion_r3051849651
