On Wed, 8 Apr 2026 14:43:24 GMT, Eirik Bjørsnøs <[email protected]> wrote:
>> Please review this PR which updates the specification of >> `ZipOutputStream.setComment(String)` to match the long-standing behavior of >> throwing `IllegalArgumentException` when a comment contains characters which >> are unmappable using the `Charset` passed in the constructor. >> >> A new tests is added to reproduce calling setComment with unmappable >> characters and verify that it throws IAE. >> >> PR work revealed that setComment does not explicitly specify behavior if the >> comment string is null or an empty string. The method spectifications of >> `ZipOutputStream::setComment` and `ZipEntry::setComment` are updated to >> clarify the consequences of such string values. >> >> A CSR has been drafted. Its specification section will be updated after an >> initial round of review of the specification text in this PR. > > Eirik Bjørsnøs has updated the pull request incrementally with one additional > commit since the last revision: > > Add missing period at end of two-arg constructor description Marked as reviewed by alanb (Reviewer). Latest spec update looks good, thanks for persisting through all the iterations to get this clear. ------------- PR Review: https://git.openjdk.org/jdk/pull/30338#pullrequestreview-4076522516 PR Comment: https://git.openjdk.org/jdk/pull/30338#issuecomment-4207679517
