On Thu, 9 Apr 2026 15:03:33 GMT, Chen Liang <[email protected]> wrote:
>> Alan Bateman has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix typo in test methd name > > test/jdk/java/util/ServiceLoader/linkageerrors/test1/Provider1.java line 1: > >> 1: /* > > These files introduce a lot of license headers - I wonder if it would be > better for `LinkageErrorsTest` to compile these source code as text blocks > using `InMemoryJavaCompiler` (`@library /test/lib`) and dump all classes > except the ones you want to remove into the `test.classes` directory. Each source file is required to have a copyright header. I agree it is a bit tedious when there are a lot of tiny source files. So moving the into text blocks might be better, or at least make it more maintenance if we add more tests for these error cases. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30405#discussion_r3059892511
