On Thu, 9 Apr 2026 20:09:30 GMT, Chen Liang <[email protected]> wrote:
>> Each source file is required to have a copyright header. I agree it is a bit >> tedious when there are a lot of tiny source files. So moving the into text >> blocks might be better, or at least make it more maintable if we add more >> tests for these error cases. > > Another advantage with no extra source files is that they allow tests, say > `LinkageErrorsTest.java`, to live in `ServiceLoader` instead of a dedicated > `linkageerrors` subdirectory - this is also more friendly to IDE-based > directory browsing. Ultimately it's up to you to decide; if we do decide that > we want more simple declarations for such multi-package or multi-module > tests, there are many tests that we can go through in the codebase in a later > effort. There will always be a need for tests that have multiple source files, packages, and modules. For this one then we can move the sources into text blocks, compile, and use a URLClassLoader to load so that there is no interference between supporting classes of the same name. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30405#discussion_r3062207878
