> ROL, ROR, LSHL, ASHR, LSHR in VectorOperators.java were declared with > VO_SHIFT but missing VO_NOFP, allowing them to pass the opCode() guard on > floating-point vectors (DoubleVector, FloatVector). > > This bug fix patch adds VO_NOFP to all five declarations. > > As a result, C2 only compiles the hot code path comprising of opCode() check, > sees the illegalOperation throw an exception, cold path comprising of > VectorSupport.binaryOp intrinsic not compiled and thus flow never reaches > vop2ideal() which generates a fatal error if shift class operation is > performed over floating point type > > Please review and share your feedback. > > Best Regards, > Jatin
Jatin Bhateja has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Review comments resolution - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8381579 - 8381579: C2: "fatal error: LROTATE: double" when using VectorAPI ------------- Changes: - all: https://git.openjdk.org/jdk/pull/30642/files - new: https://git.openjdk.org/jdk/pull/30642/files/2997a0b5..528f1f87 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=30642&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=30642&range=00-01 Stats: 805211 lines in 4935 files changed: 415501 ins; 343313 del; 46397 mod Patch: https://git.openjdk.org/jdk/pull/30642.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/30642/head:pull/30642 PR: https://git.openjdk.org/jdk/pull/30642
