On Fri, 10 Apr 2026 07:26:22 GMT, Jatin Bhateja <[email protected]> wrote:
>> ROL, ROR, LSHL, ASHR, LSHR in VectorOperators.java were declared with >> VO_SHIFT but missing VO_NOFP, allowing them to pass the opCode() guard on >> floating-point vectors (DoubleVector, FloatVector). >> >> This bug fix patch adds VO_NOFP to all five declarations. >> >> As a result, C2 only compiles the hot code path comprising of opCode() >> check, sees the illegalOperation throw an exception, cold path comprising of >> VectorSupport.binaryOp intrinsic not compiled and thus flow never reaches >> vop2ideal() which generates a fatal error if shift class operation is >> performed over floating point type >> >> Please review and share your feedback. >> >> Best Regards, >> Jatin >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Jatin Bhateja has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains three additional > commits since the last revision: > > - Review comments resolution > - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8381579 > - 8381579: C2: "fatal error: LROTATE: double" when using VectorAPI Looks good to me, thanks for making the changes. ------------- Marked as reviewed by qamai (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/30642#pullrequestreview-4104656473
