On Fri, 24 Apr 2026 18:10:00 GMT, Vladimir Ivanov <[email protected]> wrote:
>> Quan Anh Mai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> add benchmark > > Another idea for an alternative solution: ignore nodes allocated during > parsing of `@FI` methods in `Compile::over_inlining_cutoff()`. It would align > with how `DesiredMethodLimit` is handled. Also, `InlineSmallCode` is tweaked > in a similar fashion. @iwanowww Looking at the history of `LiveNodeCountInliningCutoff`, it was initially set to 20000 by default, but then later changed to 40000 in https://github.com/openjdk/jdk/commit/5a00d5f6b559850dfd65488e56202586854b65cd for [JDK-8058148](https://bugs.openjdk.org/browse/JDK-8058148). As a result, I think it is perferrable to set it to 20000 by default and increase it upon encountering a method handle call, similar to how we handle `MaxNodeLimit`. I think it will reduce the chance of overinlining. What do you think? The benchmarks have finished, I think there is no regression and maybe one or two improvements. ------------- PR Comment: https://git.openjdk.org/jdk/pull/30874#issuecomment-4321111364
