On Sun, 26 Apr 2026 02:45:39 GMT, Quan Anh Mai <[email protected]> wrote:
> I think it will reduce the chance of overinlining. What do you think? I agree that lower `LiveNodeCountInliningCutoff` reduces node budget for inlining when no MH-related code is present in the compilation context. But `LiveNodeCountInliningCutoff` effects were limited to incremental inlining through indy/MH call sites. So, I don't think it makes initial value favorable in any respect. Maybe just start with `NodeCountInliningCutoff` and bump `_live_node_count_inlining_cutoff` to `LiveNodeCountInliningCutoff` when MHs/VHs are present (if you want to preserve that logic)? It makes sense to add a diagnostic flag to revert inlining heuristic to original behavior (to simplify performance analysis in the field). BTW, please, fix `MaxNodeLimit` usages separately. > The benchmarks have finished, I think there is no regression and maybe one or > two improvements. Good. ------------- PR Comment: https://git.openjdk.org/jdk/pull/30874#issuecomment-4329830538
