On Wed, 29 Apr 2026 14:10:22 GMT, Lance Andersen <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains seven additional
>> commits since the last revision:
>>
>> - remove additional sentence from constructor documentation
>> - Lance's review - clarify implicit vs explicit close()
>> - merge latest from master branch
>> - merge latest from master branch
>> - merge latest from master branch
>> - minor doc update
>> - 8322256: Define and document GZIPInputStream concatenated stream semantics
>
> src/java.base/share/classes/java/util/zip/GZIPInputStream.java line 49:
>
>> 47: *
>> 48: * @apiNote
>> 49: * The {@link #close} method should be called to release resources used
>> by this stream.
>
> Given this supports AutoClosable, should we expand this note?
Hello Lance, I've now updated this to include a mention about
try-with-resources. The updated sentence is copied over from the existing one
in `InflaterInputStream`. Previously I wasn't sure why we needed that part, but
now that you asked this question, I understand that it helps clarify that an
explicit `close()` isn't necessary in the application code.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30925#discussion_r3168143550
