On Wed, 29 Apr 2026 14:24:43 GMT, Lance Andersen <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> refer to section 2.2 of the RFC
>
> src/java.base/share/classes/java/util/zip/GZIPInputStream.java line 176:
>
>> 174: * from one particular member i.e. a call to {@code read()} will
>> not result in {@code buf}
>> 175: * containing decompressed data from two or more members of a
>> concatenated GZIP stream.
>> 176: *
>
> Did you give any thought of discussing concatenated gzip files right after
> the file format discussion?
>
> Reason I ask as it might be a bit cleaner to have the format discussion and
> processing together>
My initial thought was to include some of these details in the class level doc.
However, when trying to word that text, I almost always either had to refer to
the `read()` method and/or the buffer passed to the read method. Unless of
course I split some of that text in the class level doc and some in the read()
method doc. I decided that it would be better to explain these details here as
a method level doc. That way we can be a bit more precise on how we word it.
If there's a better way to word it and place it as class level doc, then let me
know and I'll give it a try.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30925#discussion_r3168268792
