On Fri, 1 May 2026 13:10:48 GMT, Markus Grönlund <[email protected]> wrote:
>> Greetings, >> >> please see [JDK-8382332](https://bugs.openjdk.org/browse/JDK-8382332) for >> detailed information about this issue. >> >> Testing: jdk_jfr, tier1-6, SpecJbb2015 >> >> Thanks >> Markus >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Markus Grönlund has updated the pull request incrementally with one > additional commit since the last revision: > > intrinsics I did a pass over the updated implementation that uses the injected fields and it looks good. src/hotspot/share/utilities/unsigned5.hpp line 283: > 281: if (len == 0) break; > 282: _position += len; > 283: ++actual; This looks like a pre-existing bug, should it be tracked separately? test/jdk/jdk/jfr/jvm/TestJdkEpochThrottle.java line 92: > 90: validate(secondRecording, 3); > 91: secondRecording.close(); > 92: validate(firstRecording, 9); I haven't seen a test that has two recordings in use at the same time. The event isn't explicitly enabled for secondRecording, is the nesting relevant here? Also does the stop + start guaranteed to bump the epoch? ------------- PR Review: https://git.openjdk.org/jdk/pull/30922#pullrequestreview-4243574573 PR Review Comment: https://git.openjdk.org/jdk/pull/30922#discussion_r3201562386 PR Review Comment: https://git.openjdk.org/jdk/pull/30922#discussion_r3201079617
