On Thu, 7 May 2026 12:56:32 GMT, Alan Bateman <[email protected]> wrote:
>> Markus Grönlund has updated the pull request incrementally with one >> additional commit since the last revision: >> >> intrinsics > > src/hotspot/share/utilities/unsigned5.hpp line 283: > >> 281: if (len == 0) break; >> 282: _position += len; >> 283: ++actual; > > This looks like a pre-existing bug, should it be tracked separately? Its a pre-existing bug, indeed. I will refactor it. > test/jdk/jdk/jfr/jvm/TestJdkEpochThrottle.java line 92: > >> 90: validate(secondRecording, 3); >> 91: secondRecording.close(); >> 92: validate(firstRecording, 9); > > I haven't seen a test that has two recordings in use at the same time. The > event isn't explicitly enabled for secondRecording, is the nesting relevant > here? Also does the stop + start guaranteed to bump the epoch? We have many JFR tests that start multiple, nested recordings. Since a recording cannot turn off an event enabled by another recording, and there is only one recording stream in total, the second recording inherits the enabled event (the event setting is a union of 1 v 0, which means the event is also enabled for the subsequent recording. Start and stop are both implemented as rotations, and rotations use a stop-the-world safepoint to bump the epoch. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30922#discussion_r3202052998 PR Review Comment: https://git.openjdk.org/jdk/pull/30922#discussion_r3202045043
