On Fri, 5 Jun 2026 06:35:56 GMT, Emanuel Peter <[email protected]> wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments resolution
>
> src/hotspot/share/opto/vectorIntrinsics.cpp line 320:
>
>> 318: static bool is_unsupported_lane_type(VectorSupport::LaneType laneType) {
>> 319: return laneType == VectorSupport::LaneType::LT_FLOAT16;
>> 320: }
>
> The safer way would have been to invert the condition.
> Suppose we add yet another lane type. And forget to add it to the
> `unsupported` list in some platform. And then we get a bug. That would be
> annoying.
Hi @eme64 , This helper is transient. The plan is is to remove call sites one
by one as each inline expander gains
full Float16 support, and to delete the function entirely once Float16 reaches
parity with the other lane types
> test/hotspot/jtreg/compiler/vectorapi/TestCastIIToConvHF2FNoSp.java line 27:
>
>> 25: /**
>> 26: * @test
>> 27: * @bug 8373574
>
> Is this bug number accurate? Do you want to add the current one too?
Done
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28002#discussion_r3361148516
PR Review Comment: https://git.openjdk.org/jdk/pull/28002#discussion_r3361149185
