On Wed, 17 Jun 2026 15:13:26 GMT, Martin Doerr <[email protected]> wrote:
>> David Simms has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 2822 commits: >> >> - Merge branch '8317277' into jep401_sub_review_8317278 >> - Merge remote-tracking branch 'valhalla/lworld' into 8317277 >> - 8386690: [lworld] cherry-pick JDK-8386124 Test >> serviceability/sa/TestG1HeapRegion.java failed: Address of G1HeapRegion does >> not match >> >> Reviewed-by: liach >> - 8385743: [lworld] investigate and address build related comments in the >> Valhalla PR >> >> Reviewed-by: liach, erikj >> - 8376346: [lworld] Basic Shenandoah support >> >> Reviewed-by: qamai >> - 8386598: [lworld] C1 acmp profiling fix and minor cleanup >> >> Reviewed-by: mchevalier >> - 8386618: [lworld] Remove unused entry_guard_Relocation >> >> Reviewed-by: chagedorn, jsjolen, jsikstro >> - Merge >> >> Merge jdk-28+2 >> - 8386623: [lworld] Cleanup module support for system modules in JDK >> exploded build with preview resources >> >> Reviewed-by: liach >> - 8386316: [lworld] Replace Valhalla since version with 28 >> >> Reviewed-by: darcy >> - ... and 2812 more: https://git.openjdk.org/jdk/compare/6def7d55...c2d3cf01 > > src/hotspot/cpu/x86/stubGenerator_x86_64_arraycopy.cpp line 3612: > >> 3610: // Check for flat inline type array -> return -1 >> 3611: __ testl(rax_lh, Klass::_lh_array_tag_flat_value_bit_inplace); >> 3612: __ jcc(Assembler::notZero, L_failed); > > Is this redundant? See check with same comment above. Other platforms don't > do this. Addressed with [JDK-8387274](https://bugs.openjdk.org/browse/JDK-8387274). ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31122#discussion_r3472488056
