On Mon, 13 Jul 2026 23:06:41 GMT, Naoto Sato <[email protected]> wrote:
>> Sholto has updated the pull request incrementally with one additional commit >> since the last revision: >> >> 8272194: expand dates covered by faster code path in >> LocalDate/LocalDateTime conversion > > test/jdk/java/sql/test/sql/TimestampTests.java line 733: > >> 731: assertTrue(bcTimestamp.toLocalDateTime().getYear() <= 0, >> "Expected a BC year."); >> 732: assertEquals(bcTimestamp.toLocalDateTime(), >> bcLocalDateTime, "The LocalDateTime created from the Timestamp does not >> match the original BC LocalDateTime."); >> 733: >> assertEquals(Timestamp.valueOf(bcTimestamp.toLocalDateTime()), bcTimestamp, >> "The BC Timestamp did not yield the expected result on a round trip >> Timestamp / LocalDateTime conversion."); > > The `expected` and `actual` arguments to `assertEquals` appear to be reversed. I have fixed this while making the `@ParameterizedTest` change. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31808#discussion_r3577484836
