On Tue, 14 Jul 2026 18:15:36 GMT, Justin Lu <[email protected]> wrote:
>> Can I just double check, do you think that we should be using `getYear()` >> for the BC path as well? > > Yes, I believe year should always be derived from `getYear()`. Cool I have made that changed. I have also moved away from the if-else block to only a BC if block. This brings the logic inline with how it is done in the `GregorianCalendar` class. I realise that with always using `getYear()` we could also create a faster code path for BC dates by also adding a year 2 BC epoch millisecond and checking if `getTime()` is less than that. That way we only do the calendar check for the narrow band of dates we cannot be certain are BC or AD. However, I recognise this is an extra optimisation which few consumers would benefit from. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31808#discussion_r3581742297
