On Thu, 16 Jul 2026 17:45:06 GMT, Chen Liang <[email protected]> wrote:

>> A few fail-safe convenience methods added in #23548 are missing necessary 
>> null checks. In addition, the `PackageEntry` symbolic conversion and testing 
>> methods are not correctly rejecting `PackageDesc` representing the unnamed 
>> package, a deliberate choice when `PackageDesc` was added to Java.
>> 
>> Luckily, these oversights can be easily fixed and verified with minor 
>> enhancements to existing tests. There are also accompanying minor doc 
>> enhancements about the situation.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Chen Liang has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Replicable pool states

Looks good to me.

-------------

Marked as reviewed by asotona (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/31925#pullrequestreview-4716365979

Reply via email to