> A few fail-safe convenience methods added in #23548 are missing necessary 
> null checks. In addition, the `PackageEntry` symbolic conversion and testing 
> methods are not correctly rejecting `PackageDesc` representing the unnamed 
> package, a deliberate choice when `PackageDesc` was added to Java.
> 
> Luckily, these oversights can be easily fixed and verified with minor 
> enhancements to existing tests. There are also accompanying minor doc 
> enhancements about the situation.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Chen Liang has updated the pull request with a new target base due to a merge 
or a rebase. The incremental webrev excludes the unrelated changes brought in 
by the merge/rebase. The pull request contains seven additional commits since 
the last revision:

 - More coverage
 - Merge branch 'master' of https://github.com/openjdk/jdk into 
fix/cf-match-inconsistencies
 - Stage
 - Merge branch 'master' of https://github.com/openjdk/jdk into 
fix/cf-match-inconsistencies
 - Replicable pool states
 - Wording tweak
 - Match method null check and inconsistencies

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/31925/files
  - new: https://git.openjdk.org/jdk/pull/31925/files/79abfe7a..9d1675f4

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=31925&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=31925&range=01-02

  Stats: 12938 lines in 265 files changed: 7158 ins; 4249 del; 1531 mod
  Patch: https://git.openjdk.org/jdk/pull/31925.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/31925/head:pull/31925

PR: https://git.openjdk.org/jdk/pull/31925

Reply via email to