On Fri, 31 Jul 2026 03:28:06 GMT, Joe Darcy <[email protected]> wrote:
>> Chen Liang has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> commits since the last revision: >> >> - Update usage in Valhalla >> - Merge branch 'master' of https://github.com/openjdk/jdk into >> feature/class-is-class-or-interface-1 >> - Simplify code >> - Merge branch 'master' of https://github.com/openjdk/jdk into >> feature/class-is-class-or-interface-1 >> - Class.isClassOrInterface > > src/java.base/share/classes/java/lang/Class.java line 907: > >> 905: >> 906: /** >> 907: * Determines if this {@code Class} object represents a class or an >> interface. > > Are hidden classes intended to be classes-or-interfaces under this method? > > Trying to tease apart if the goal is an "is-declared-type" predicate or an > "is-class-or-interface" predicate. Those two might only diff on hidden > classes. Yes, there are hidden classes and interfaces. They are derived from class files, and they can declare methods and fields, even though other class files cannot link against them. In fact, my unit tests have cases where I test against hidden classes. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32109#discussion_r3687979254
