On Fri, 31 Jul 2026 00:54:13 GMT, Chen Liang <[email protected]> wrote:

>> Introduce an instance method, `isClassOrInterface`, to `java.lang.Class` and 
>> `java.lang.invoke.TypeDescriptor$OfField`.
>> 
>> `java.lang.constant.ClassDesc` comes with an `isClassOrInterface` method. It 
>> turns out that such a check is frequently needed in the use of `Class` 
>> objects, usually as `isArray() || isPrimitive()` or `!isArray() && 
>> !isPrimitive()`, with 14 occurrences in various reflective code.
>> 
>> In addition, `Class` can offer a more efficient implementation than two 
>> checks: it can perform a single bit pattern check to derive this result, 
>> making such an API more feasible.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Chen Liang has updated the pull request with a new target base due to a merge 
> or a rebase. The incremental webrev excludes the unrelated changes brought in 
> by the merge/rebase. The pull request contains five additional commits since 
> the last revision:
> 
>  - Update usage in Valhalla
>  - Merge branch 'master' of https://github.com/openjdk/jdk into 
> feature/class-is-class-or-interface-1
>  - Simplify code
>  - Merge branch 'master' of https://github.com/openjdk/jdk into 
> feature/class-is-class-or-interface-1
>  - Class.isClassOrInterface

test/jdk/java/lang/Class/IsClassOrInterface.java line 78:

> 76:                 IsClassOrInterface.class,
> 77:                 makeHiddenClass("MyHiddenClass.class"),
> 78:                 makeHiddenClass("MyHiddenInterface.class")

@jddarcy Here's the test case where I explicitly expect hidden classes to be 
considered "classes and interfaces".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32109#discussion_r3687982512

Reply via email to