The failure handler keys each HTML section id by the command's name path, so
when a command name occurs again after an intervening command - the same
command repeated, or the same top-level tool reused, as in
"jcmd.compiler.codecache jinfo jcmd.compiler.codelist" - a second section with
the same id is written. Anchors and the data-toggle / data-show javascript
resolve ids via document.getElementById, which returns the first match, so the
later occurrence's output is unreachable. These are the two cases reported in
the bug.
Fix: the root section keeps a registry of issued ids; a repeated id gets the
first free numeric suffix ("jcmd-2", ...). Displayed names are unchanged,
adjacent commands with a shared prefix still share their sections, children of
a suffixed section are unique automatically, and the registry also prevents
collisions with a command literally named like a suffix. The only external id
reconstruction, ToolKit.link(), is keyed by PID and unaffected.
Ids can still repeat across appended fragments (each invocation appends a
complete HTML document); that is pre-existing and tracked as JDK-8389541.
Verified with a standalone driver using both sequences from the bug: six
duplicated ids before the fix, none after, every run's output reachable. New
HtmlSectionTest (plain JUnit, like the existing unit tests) covers both
reported cases, per-occurrence output association, triple repetition, the
"jcmd-2" name collision, and the unchanged adjacent / shared-prefix behavior -
6/6 pass.
---------
- [x] I confirm that I make this contribution in accordance with the [OpenJDK
Interim AI Policy](https://openjdk.org/legal/ai).
-------------
Commit messages:
- 8337680: failure_handler does not handle repeated commands well
Changes: https://git.openjdk.org/jdk/pull/32157/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=32157&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8337680
Stats: 183 lines in 2 files changed: 180 ins; 0 del; 3 mod
Patch: https://git.openjdk.org/jdk/pull/32157.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/32157/head:pull/32157
PR: https://git.openjdk.org/jdk/pull/32157
