On Fri, 7 Aug 2026 11:51:04 GMT, Jaikiran Pai <[email protected]> wrote:
>> Shiv Shah has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove bug id from comment and always initialize sectionIds
>
> test/failure_handler/src/share/classes/jdk/test/failurehandler/HtmlSection.java
> line 75:
>
>> 73: } else {
>> 74: this.rootSection = rootSection;
>> 75: this.sectionIds = null;
>
> Is setting to `null` necessary or can we always initialize `sectionIds` to an
> empty `HashSet`? It makes things a bit easier at call sites and avoids null
> checks. On a related note, the place where this `sectionIds` is currently
> being used doesn't do a null check, so that might be another reason to just
> always initialize this set to a non-null value.
it was intentional, only the root’s set is ever used and uniqueId always goes
through rootSection, so the child field never gets read. but agreed the empty
set reads better, changed it
> test/failure_handler/src/share/classes/jdk/test/failurehandler/HtmlSection.java
> line 165:
>
>> 163: * anchors, {@code data-toggle} and {@code data-show} references
>> resolve to
>> 164: * the right occurrence when a command name is repeated
>> (JDK-8337680).
>> 165: */
>
> Hello Shiv, we don't usually include the JBS issue ids in the code comments.
> I think leaving it out would be preferable. The rest of the text seems
> reasonable.
removed it, thanks.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32157#discussion_r3736506469
PR Review Comment: https://git.openjdk.org/jdk/pull/32157#discussion_r3736501223
