On Wed, 19 Aug 2026 07:10:45 GMT, Jaikiran Pai <[email protected]> wrote:
> Can I please get a review of this doc-only change which updates the text in > the `jar --help` output as well as the `jar` man page to clarify the usage of > the `-C` option? > > As noted in https://bugs.openjdk.org/browse/JDK-8390615, the current examples > in the `jar --help` can cause confusion on the expectations of the `-C` > option. The updated text in the man page will also address a related issue > noted in https://bugs.openjdk.org/browse/JDK-8389482. > > While at it, trivial adjustment to the text in `jar --help` and `jar` man > page has been done to use "JAR" (instead of "jar") whenever referencing to a > JAR file. > > I've run manual experiments to verify that these commands now work as > described. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). src/jdk.jartool/share/classes/sun/tools/jar/resources/jar.properties line 374: > 372: \ --version Print program version > 373: main.help.postopt=\ > 374: \ A JAR is a modular JAR if a module descriptor, 'module-info.class', > is\n\ In the JAR file spec, this is introduced as "A modular JAR file is a JAR file that has a module descriptor, module-info.class, in the top-level directory (or root) directory". So I think we should at least use "JAR file" throughout to avoid having a mix of "JAR" and "JAR file" in the man page. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32439#discussion_r3811125711
