On Wed, 19 Aug 2026 08:00:25 GMT, Alan Bateman <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Alan's review - use "JAR file" when explaining what a module JAR file is > > src/jdk.jartool/share/classes/sun/tools/jar/resources/jar.properties line 374: > >> 372: \ --version Print program version >> 373: main.help.postopt=\ >> 374: \ A JAR is a modular JAR if a module descriptor, 'module-info.class', >> is\n\ > > In the JAR file spec, this is introduced as "A modular JAR file is a JAR file > that has a module descriptor, module-info.class, in the top-level directory > (or root) directory". So I think we should at least use "JAR file" > throughout to avoid having a mix of "JAR" and "JAR file" in the man page. Using "JAR file" here sounds good to me. I've updated `jar.properties` and `jar.md` to adjust this sentence when explaining what makes a modular JAR file. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32439#discussion_r3811204106
