On Thu, 13 Aug 2026 11:32:22 GMT, Alan Bateman <[email protected]> wrote:

>>> @AlanBateman Could you please take a look this change? Thanks!
>> 
>> I looked through the changes and they look okay. We could potentially 
>> re-visit IsModuleOption and IsLongFormModuleOption so they aren't just for 
>> module options. The only special thing is the mapping of -p to its long form.
>
>> Hi @AlanBateman, is there anything else I need to change to move this PR 
>> forward?
> 
> The update is okay, it's just the FinalizationOption test update where there 
> may be a better approach.

> @AlanBateman, I have updated the FinalizationOption test following the 
> suggested approach. Could you please take another look when you have time? 
> Thanks!

Thank you, I don't have any other comments to add.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/31928#issuecomment-5406146168

Reply via email to