On Mon, 21 Sep 2026 07:30:08 GMT, Jaikiran Pai <[email protected]> wrote:
>> Chen Liang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Don't overmask > > src/java.base/share/classes/java/lang/runtime/ValueObjectMethods.java line > 176: > >> 174: // to enable caching. The identity hash of the value class >> distinguishes >> 175: // different value classes and is easy for the compiler to >> fetch. >> 176: return (result & U.hashCodeMask()) == 0 ? typeHash : result; > > Should this comment be updated: >> Use an alternative non-zero value when the computed hash is zero, > > It contradicts the check, since we aren't comparing the computed hash code > `result` with `0`: > >> (result & U.hashCodeMask()) == 0 I don't think think it is really wrong, but I attempted to make the comment clearer. Is that better? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32660#discussion_r4060129731
