On Tue, 22 Sep 2026 19:09:02 GMT, sbracely <[email protected]> wrote:
>> createEpochMonths() used minYear in the invalid-month-length message.
>> Use the loop variable year.
>>
>> HijrahConfigTest copies an invalid custom config and checks
>> the DateTimeException cause message names 1448.
>>
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> sbracely has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show differences
> compared to the previous content of the PR. The pull request contains one new
> commit since the last revision:
>
> 8392848: HijrahChronology.createEpochMonths reports minYear instead of the
> invalid year
test/jdk/java/time/nonjunit/java/time/chrono/HijrahConfigTest.java line 46:
> 44: public class HijrahConfigTest {
> 45:
> 46: private static final String TEST_CONFIG =
> "hijrah-config-Hijrah-test_islamic-test.properties";
Since there are now two test properties, I'd rename this "test" one to "valid"
test/jdk/java/time/nonjunit/java/time/chrono/hijrah-config-Hijrah-invalid_islamic-invalid.properties
line 43:
> 41: # 1 2 3 4 5 6 7 8 9 10 11 12
> 42: 1447=30 29 30 29 30 29 30 29 30 29 30 29
> 43: 1448=28 29 30 29 30 29 30 29 30 29 30 29
Nit: needs a newline
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33015#discussion_r4086738489
PR Review Comment: https://git.openjdk.org/jdk/pull/33015#discussion_r4086747211
