On Wed, 23 Sep 2026 21:01:08 GMT, sbracely <[email protected]> wrote: >> createEpochMonths() used minYear in the invalid-month-length message. >> Use the loop variable year. >> >> HijrahConfigTest copies an invalid custom config and checks >> the DateTimeException cause message names 1448. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > sbracely has updated the pull request incrementally with one additional > commit since the last revision: > > 8392848: HijrahChronology.createEpochMonths reports minYear instead of the > invalid year
Marked as reviewed by jlu (Reviewer). test/jdk/java/time/nonjunit/java/time/chrono/hijrah-config-Hijrah-valid_islamic-valid.properties line 1: > 1: # Copyright (c) 2020, Oracle and/or its affiliates. All rights reserved. nit - needs copyright year bump now ------------- PR Review: https://git.openjdk.org/jdk/pull/33015#pullrequestreview-5296778854 PR Review Comment: https://git.openjdk.org/jdk/pull/33015#discussion_r4087297134
