On Fri, 25 Sep 2026 06:36:50 GMT, Jaikiran Pai <[email protected]> wrote:
> Can I please get a review of this change which proposes to improve the error > message when a JAR file with no manifest is used to launch a java application > using `java -jar <jarfile>` command? This addresses > https://bugs.openjdk.org/browse/JDK-8392966. > > With the changes in this PR, for a JAR without a manifest file, if it is > launched using `java -jar foo.jar` command then the error message will now > say: > >> Error: No manifest in JAR file foo.jar > > An existing jtreg test has been converted to junit and a new test method has > been introduced to verify this change. tier1, tier2 and tier3 continue to > pass after this change. > > > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). src/java.base/share/native/libjli/emessages.h line 28: > 26: /* > 27: * This file primarily consists of all the error and warning messages, > that > 28: * are used in JLI_ReportErrorMessage. I have talked to Naoto and Justin and they have confirmed that these error messages were never localized. So this inaccurate sentence has now been removed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33064#discussion_r4101851762
