On Wed, 30 Sep 2026 21:02:54 GMT, Naoto Sato <[email protected]> wrote:
>> Tagir F. Valeev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8391789: Empty input test fixed
>
> src/java.base/share/classes/java/util/stream/Collectors.java line 351:
>
>> 349: *
>> 350: * <p>For example, if the input stream contains three elements
>> {@code "a"}, {@code "b"},
>> 351: * and {@code "c"}, collecting it with {@code
>> joiningConjunctively(Locale.ENGLISH)}
>
> Since the example uses the Oxford comma, I'd prefer `Locale.US` over the
> language-only `Locale.ENGLISH`. For comparison, `Locale.UK` formats the same
> list without the Oxford comma.
Thank you, updated. Also, updated the tests correspondingly, to make it more
precise
> src/java.base/share/classes/java/util/stream/Collectors.java line 372:
>
>> 370: *
>> 371: * <p>For example, if the input stream contains three elements
>> {@code "a"}, {@code "b"},
>> 372: * and {@code "c"}, collecting it with {@code
>> joiningConjunctively(Locale.ENGLISH)}
>
> You meant `joiningDisjunctively` here, right?
Thank you, fixed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32716#discussion_r4152542489
PR Review Comment: https://git.openjdk.org/jdk/pull/32716#discussion_r4152543114
