On Fri, 16 Oct 2026 21:14:47 GMT, Patricio Chilano Mateo 
<[email protected]> wrote:

>> Fredrik Bredberg has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Update for Patricio
>
> src/hotspot/share/runtime/threadSMR.cpp line 971:
> 
>> 969:   }
>> 970:   _retired_since_reclaim_cnt = 0;
>> 971:   _retired_since_reclaim_mem = 0;
> 
> If we don’t delete any list below (or just a few) the number of retired 
> `ThreadsLists` and memory used can keep growing past the 16 and 4M thresholds 
> before the next reclaim attempt. Was the intended policy to trigger the next 
> reclaim attempt based on newly retired lists, or should the counters be 
> updated based on lists removed below? If it should be based on removed lists, 
> the counters would also need to be incremented when `thread_to_delete != 
> nullptr` above.

The intended policy is to trigger the next reclaim attempt based on newly 
retired lists.
I've added a comment in the source to clarify this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33166#discussion_r4315879915

Reply via email to