On Fri, 9 Oct 2026 15:46:21 GMT, Daniel D. Daugherty <[email protected]> wrote:
>> Fredrik Bredberg has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update Daniel
>
> src/hotspot/share/runtime/threadSMR.cpp line 943:
>
>> 941: // The bootstrap list cannot be freed and is empty so
>> 942: // it does not need to be scanned. Nothing to do here.
>> 943: log_debug(thread, smr)("tid=%zu: ThreadsSMRSupport::free_list:
>> bootstrap ThreadsList=" INTPTR_FORMAT " is no longer in use.",
>> os::current_thread_id(), p2i(threads));
>
> Not your issue, but I don't understand this debug mesg.
>
> If we are passed a `threads` value that matches the bootstrap list,
> then we have no work to do because we are early in the VM's life.
> So what does "is no longer in use" mean?
I think the original author meant that **the bootstrap-list is no longer
used**, because it's been replaced by a new current list.
> src/hotspot/share/runtime/threadSMR.cpp line 957:
>
>> 955:
>> 956: // We can defer a reclamation attempt if free_list() was called when
>> adding
>> 957: // a thread (i.e. thread_to_delete == nullptr). This amortizes the
>> cost of
>
> nit: s/i.e./i.e.,/
Fixed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33166#discussion_r4327271771
PR Review Comment: https://git.openjdk.org/jdk/pull/33166#discussion_r4327207236
