On Thu, 29 Oct 2026 22:18:28 GMT, Maurizio Cimadamore <[email protected]>
wrote:
>> Jorn Vernee has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Rephrase more
>> - Rephrase doc
>
> test/jdk/java/foreign/normalize/TestZeroExtend.java line 49:
>
>> 47:
>> 48: static {
>> 49: System.loadLibrary("Normalize");
>
> Where is the native lib for this? I don't see any C file...
>
> Also, we should make sure that said lib is compiled with O1,2 -- otherwise
> the test could pass even w/o the fix (I think)
Ah I see -- the native lib was already there. Still, we should make sure to
test against a library compiled with some (C) optimizations
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33417#discussion_r4418511764
