On Mon, 2 Nov 2026 09:52:36 GMT, Martin Doerr <[email protected]> wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional >> commit since the last revision: >> >> re-add requires tag > > I have seen test errors while running > tools/sincechecker/modules/java.base/JavaBaseCheckSince.java: > > src/java.base/java/lang/foreign/ValueLayout.java:255 method: > java.lang.foreign.ValueLayout.OfByte > java.lang.foreign.ValueLayout.OfByte.withSignedness(boolean): `@since` > version: 22; should be: 28 > src/java.base/java/lang/foreign/ValueLayout.java:333 method: > java.lang.foreign.ValueLayout.OfShort > java.lang.foreign.ValueLayout.OfShort.withSignedness(boolean): `@since` > version: 22; should be: 28 > src/java.base/java/lang/foreign/ValueLayout.java:375 method: > java.lang.foreign.ValueLayout.OfInt > java.lang.foreign.ValueLayout.OfInt.withSignedness(boolean): `@since` > version: 22; should be: 28 > src/java.base/java/lang/foreign/ValueLayout.java:452 method: > java.lang.foreign.ValueLayout.OfLong > java.lang.foreign.ValueLayout.OfLong.withSignedness(boolean): `@since` > version: 22; should be: 28 > src/java.base/java/lang/foreign/ValueLayout.java:142 class: > java.lang.foreign.ValueLayout.OfIntegral: `@since` version: 22; should be: 28 > src/java.base/java/lang/foreign/ValueLayout.java:147 method: boolean > java.lang.foreign.ValueLayout.OfIntegral.isSigned(): `@since` version: 22; > should be: 28 > src/java.base/java/lang/foreign/ValueLayout.java:155 method: > java.lang.foreign.ValueLayout.OfIntegral > java.lang.foreign.ValueLayout.OfIntegral.withSignedness(boolean): `@since` > version: 22; should be: 28 > src/java.base/java/lang/foreign/ValueLayout.java:160 method: > java.lang.foreign.ValueLayout.OfIntegral > java.lang.foreign.ValueLayout.OfIntegral.withName(java.lang.String): `@since` > version: 22; should be: 28 > src/java.base/java/lang/foreign/ValueLayout.java:166 method: > java.lang.foreign.ValueLayout.OfIntegral > java.lang.foreign.ValueLayout.OfIntegral.withoutName(): `@since` version: 22; > should be: 28 > src/java.base/java/lang/foreign/ValueLayout.java:173 method: > java.lang.foreign.ValueLayout.OfIntegral > java.lang.foreign.ValueLayout.OfIntegral.withByteAlignment(long): `@since` > version: 22; should be: 28 > src/java.base/java/lang/foreign/ValueLayout.java:179 method: > java.lang.foreign.ValueLayout.OfIntegral > java.lang.foreign.ValueLayout.OfIntegral.withOrder(java.nio.ByteOrder): > `@since` version: 22; should be: 28 @TheRealMDoerr Thanks for catching this! I've fixed the errors and added that test to the `jdk_foreign` group. (FWIW, we already have a precedent for running static analysis tests through the `jdk/internal/reflect/CallerSensitive/CheckCSMs.java` test) ------------- PR Comment: https://git.openjdk.org/jdk/pull/33417#issuecomment-6582487634
