On Mon, 2 Nov 2026 21:25:51 GMT, Sandhya Viswanathan <[email protected]>
wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments resolution
>
> test/hotspot/jtreg/compiler/vectorapi/TestGFNIUniformByteShift.java line 48:
>
>> 46: * @library /test/lib /
>> 47: * @requires vm.compiler2.enabled
>> 48: * @run driver ${test.main.class}
>
> We should also run this test with UseAVX=0, 1, and 2. So may be additional
> run directives?
Addressed.
> test/hotspot/jtreg/compiler/vectorapi/TestGFNIUniformByteShift.java line 188:
>
>> 186: applyIfCPUFeatureAnd = {"gfni", "true", "avx", "true"})
>> 187: public static void testAutoVecArithmeticRightShift() {
>> 188: for (int s = 0; s < SHIFT; s++) {
>
> Adding some out of range values for SHIFT would be good to add for auto
> vectorization tests.
Addressed.
> test/micro/org/openjdk/bench/jdk/incubator/vector/ByteShiftBenchmark.java
> line 69:
>
>> 67: }
>> 68: }
>> 69:
>
> An auto vectorizer test in the jmh would be good to add as well.
Addressed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33113#discussion_r4451668392
PR Review Comment: https://git.openjdk.org/jdk/pull/33113#discussion_r4451668759
PR Review Comment: https://git.openjdk.org/jdk/pull/33113#discussion_r4451668630
